Cleanup ofShadow and ofCubemap #8422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofTheo
reviewed
Apr 7, 2025
libs/openFrameworks/gl/ofCubeMap.cpp
Outdated
| std::shared_ptr<ofCubeMap::Data> cubeMap = ofCubeMapsData()[i].lock(); | ||
| for(size_t i=0; i<of::priv::ofCubeMapsData().size(); i++) { | ||
| if(!of::priv::ofCubeMapsData()[i].expired()) { | ||
| std::shared_ptr<of::priv::ofCubeMapData> cubeMap = of::priv::ofCubeMapsData()[i].lock(); |
Member
There was a problem hiding this comment.
Sorry - should have chimed in sooner, not sure about of::priv::ofCubeMapData
Will take a proper look but prefer: ofCubeMap::Data in general.
danomatika
reviewed
Apr 16, 2025
| }; | ||
|
|
||
| std::vector<std::weak_ptr<ofShadow::Data> > & ofShadowsData(); | ||
| //namespace of{ |
Contributor
There was a problem hiding this comment.
Can probably remove this now.
Contributor
Author
There was a problem hiding this comment.
Nice catch, submitted another PR since this was already merged #8441
dimitre
added a commit
to dimitre/openFrameworks
that referenced
this pull request
Apr 17, 2025
This was referenced May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ofShadow
Rename isGlCullingEnabled() & setGlCullingEnabled() to isCullingEnabled() && setCullingEnabled(): #8411
ofCubeMap and ofShadow, make private by wrapping in of::priv.
Added more comments and made a few more functions private to reduce confusion.
#8409